Correct / improve SymfonyProfilerController #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odolbeau
force-pushed
the
correct-controller
branch
from
a7d78ce to
e497783
Compare
odolbeau
force-pushed
the
correct-controller
branch
from
e497783 to
a5701e8
Compare
odolbeau
commented
Dec 27, 2019
| path: Twig/TranslationExtension.php | ||
|
|
||
| - | ||
| message: "#^Call to method getValue\\(\\) on an unknown class Symfony\\\\Component\\\\Translation\\\\DataCollector\\\\Data\\.$#" |
Member
Author
There was a problem hiding this comment.
Will become useless once missing use will be added in symfony
See: symfony/symfony#35122
Member
There was a problem hiding this comment.
PHPStan will also give an error when a message is not used anymore 👍 Great way of gradually improving code quality
compliments to @ondrejmirtes 👏
rvanlaak
approved these changes
Dec 27, 2019
| /** @var \Symfony\Component\HttpKernel\DataCollector\RequestDataCollector */ | ||
| $requestCollector = $this->profiler->loadProfile($token)->getCollector('request'); | ||
|
|
||
| $message |
Member
There was a problem hiding this comment.
What about reducing fluent usage? That way you don't need to rely on the message returning itself.
$message->setLocale()
$message->setTranslation()
Member
Author
There was a problem hiding this comment.
I kept the original syntax.
| - { name: 'data_collector', template: "@Translation/SymfonyProfiler/translation.html.twig", id: "translation", priority: 200 } | ||
|
|
||
| Translation\Bundle\Controller\SymfonyProfilerController: | ||
| autowire: true |
Member
There was a problem hiding this comment.
What about moving this to a _defaults section?
_defaults:
autowire: true
autoconfigure: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.